search

thoughtbot / carnival

An unobtrusive, developer-friendly way to add comments
MIT License
501 stars 30 forks source link

Fix synchronous CORS requests in Firefox 37 #249

Closed pbrisbin closed 9 years ago

pbrisbin commented 9 years ago

http://stackoverflow.com/questions/16668386/cors-synchronous-requests-not-working-in-firefox.

Put withCredentials = true within a beforeSend function. Resolves #248.

jferris commented 9 years ago

The three changes and the block around them look pretty similar. Worth extracting a function?

pbrisbin commented 9 years ago

Sure, now I'll just have to do a bit more testing before being confident enough to merge. Sure wish we had something automated...

pbrisbin commented 9 years ago

How bout now?

jferris commented 9 years ago

Lovely!