search

thoughtbot / carnival

An unobtrusive, developer-friendly way to add comments
MIT License
501 stars 30 forks source link

Re-introduce openRequest duplication #253

Closed pbrisbin closed 9 years ago

pbrisbin commented 9 years ago

As part of af142f2, the request building logic was centralized. Something about this refactor breaks CORS requests entirely.

This commit reverts that, and introduces the Firefox fix without removing the duplication, which we will address separately.

gabebw commented 9 years ago

Is this a pure git revert af142f2?

pbrisbin commented 9 years ago

This commit reverts that, and introduces the Firefox fix without removing the duplication

gabebw commented 9 years ago

I'll take that as a "no".

Have you confirmed this works on, say, the staging blog? Or is the idea to merge this and apply another fix if it doesn't work?

pbrisbin commented 9 years ago

I've confirmed this works locally. Next step is staging blog, I usually merge before testing there rather than deploying a branch.

gabebw commented 9 years ago

Reasonable. Merge away.