thoughtbot / carnival

An unobtrusive, developer-friendly way to add comments
MIT License
501 stars 30 forks source link

Call withEnv in TestImport.withApp #256

Closed pbrisbin closed 9 years ago

pbrisbin commented 9 years ago

In e7cc415f, loadEnv was moved out of makeFoundation and placed earlier in the application boot process. This unintentionally meant it was no longer invoked during tests was part of withApp. This was OK on CirclCI where the environment variables are explicitly set, but breaks tests locally where they are set in .env.

jferris commented 9 years ago

Looks good.