search

thoughtbot / carnival

An unobtrusive, developer-friendly way to add comments
MIT License
501 stars 30 forks source link

When comments run longer than the article, they bleed into footer #257

Closed pbrisbin closed 6 years ago

pbrisbin commented 9 years ago

shot

gabebw commented 9 years ago

overflow: scroll?

pbrisbin commented 9 years ago

It's a bit more complicated than that. These threads are contained in a .carnival div of no size and absolutely positioned to line up with the paragraphs. I think we would need to get that div to be the same height as the article before we can think about how to position/constrain the threads within it.

smharley commented 9 years ago

max-height might also be a band-aid

jferris commented 9 years ago

The proposed max-height band-aid has been deployed, but it would be nice to come up with a more robust fix.

pbrisbin commented 9 years ago

Wild idea: