thoughtbot / carnival

An unobtrusive, developer-friendly way to add comments
MIT License
501 stars 30 forks source link

Fix yesod devel command #284

Closed jferris closed 8 years ago

jferris commented 8 years ago

This command broke when we added the carnival-task executable. Running yesod-devel before this commit prints this error:

Starting development server...
<command line>: cannot satisfy -package-id main-inplace
    (use -v for more information)
Exit code: ExitFailure 1

Excluding the executable in library-only mode (used by yesod devel) fixes the error. After this commmit, you'll need to reconfigure and rebuild if you want to run carnival-task in development. Running yesod-devel again will automatically reconfigure in library-only mode.

Resolves #279.

jferris commented 8 years ago

cc @thoughtbot/haskell @pbrisbin

pbrisbin commented 8 years ago

LGTM -- makes sense that the build configuration now matches the existing executable more too.

jferris commented 8 years ago

makes sense that the build configuration now matches the existing executable more too.

Yeah. I originally excluded that intentionally, because you needed to manually rebuild in order to do cabal run carnival-task. In retrospect, it's kind of obvious you can't have to build configurations active at the same time, so this was a silly thing to do.