Closed jneander closed 10 years ago
I'm not sure what you mean by 'non-monkey patched'. Cocaine doesn't monkey patch true
and the tests run fine. Why is this change necessary?
The previous implementation depends on true
being patched with .true?
as a valid method for assertions. In the current implementation of cocaine, given the current dependencies, .true?
does not exist. The Travis CI builds are all failing for this reason, as were the tests when run locally after a clean clone. Changing the assertion corrects the problem.
Ah! I see. I didn't realize this was the case. Thanks for letting me know! One thing, though. Our style guide (https://github.com/thoughtbot/guides/tree/master/style#testing) prefers eq
to ==
. So if you could change that, I'll pull this in right away. Thanks!
Thank you for mentioning the style guide. Consistency is valuable. I have converted those over and confirmed the tests locally. Pending the green light from Travis CI, this should be good to merge.
Thanks very much for this!
You are most welcome!
This fixes tests breaking with non-monkey-patched 'true' and 'false' objects.