thoughtbot / cocaine

A small library for doing (command) lines.
https://robots.thoughtbot.com
Other
785 stars 55 forks source link

Command Time out #76

Closed ssugrim closed 9 years ago

ssugrim commented 9 years ago

Howdy, I was wondering how hard it would be to extend this library to include a timeout feature. When set it would raise an exception if a command took longer than the allotted amount of time (a parameter).

It would also need to detach or kill the subshell (not sure what the correct action is there, perhaps this should be a parameter too).

jyurek commented 9 years ago

I think a more flexible solution would be to have something else manage the timeouts, and wrap cocaine calls in that tool. Partly because timing things out is actually a more general problem, and partly because timing things out reliably in Ruby is surprisingly difficult. I'm not really interested in maintaining that in this library.