search

thoughtbot / cocaine

A small library for doing (command) lines.
https://robots.thoughtbot.com
Other
785 stars 55 forks source link

Dont hang on stderr #97

Closed mmangino closed 6 years ago

mmangino commented 7 years ago

This fixes #96 by using nonblocking IO and select on the fire descriptors. I added specs that failed on master before this change.

joshuapinter commented 7 years ago

This looks great @mmangino! Did you ever get feedback on this? Have you been using your fork in production?

I'm running into the same problem transcoding medium-sized video files (25mb+).

joshuapinter commented 7 years ago

Just a quick follow-up, I'm using your branch and it's working fantastic in our Rails 3 app. Terrific work! 🥇

For others, until this gets merged into the master branch you'll want to use this in your gemfile:

gem 'cocaine',                                
  github: 'HubTran/cocaine',          
  branch: 'dont_hang_on_stderr'
mmangino commented 7 years ago

I'm using this in production with no problems.

jyurek commented 6 years ago

Thanks for your answers and your work on this. I'll close this so we can continue discussion on the Terrapin PR.