thoughtbot / dotfiles

A set of vim, zsh, git, and tmux configuration files.
https://thoughtbot.com
Other
7.97k stars 1.87k forks source link

Restructure with pathogen #12

Closed cloud8421 closed 12 years ago

cloud8421 commented 12 years ago

Hi there!

Is there a reason why you're not using Pathogen to manage plugins? I've run through them and > 90% (given that most of them are by Tim Pope himself) have a Github repository available that would be perfect with Pathogen.

See here: http://vimcasts.org/episodes/synchronizing-plugins-with-git-submodules-and-pathogen/ for the benefit.

I've been doing it for a while with my previous Vim configuration and it rocks, you can easily update all of your plugins with

git submodule foreach git pull origin master

As a matter of fact, you could also structure the dot files themselves as a repo with submodules, having for example vimrc.local as a submodule you can maintain separately (everyone has its own preferences :-) ).

jasonm commented 12 years ago

It'd be awesome. I can only assume patches'd be accepted.

cloud8421 commented 12 years ago

Well let me get a run at it in a couple of days (hope you guys are at home celebrating Thanksgiving) and we'll see!

cloud8421 commented 12 years ago

Actually it took less time than expected.

https://github.com/cloud8421/dotfiles-1

I'm not making a pull request as it'd be better if you guys test it first on your end. I tested this under a clean Ubuntu install and I'd trust it to work the same on Mac (I don't have a spare one to test with now, so I'd kindly ask you to do it).

The only things I couldn't find are these:

after/indent/html.vim
plugin/ctags.vim

I copied them so they're versioned together with the rest of the main repo.

Please note that there were bundles with pretty big updates compared to your original repo, so you may experience some different behaviours. The good thing is that every bundle is on Github, so you may fork it, edit it and swap it inside the main repo with your version.

Readme has also been updated with first run instructions.

Hope you like this!

fourcolors commented 12 years ago

I like this approach as well. Thanks for making a pathogen version. Ill test it on my mac setup and give you some feedback.

fourcolors commented 12 years ago

I'm not sure I like having the git submodules. True it makes updating all of your plugins a breeze, however you risk some plugin repositories being deleted like your vim-matchit plugin for instance. It was deleted now updating your submodules breaks.

A work around could be to fork every plugin you want to use (to ensure the repository will be there) then reference those repositories. This lets you update easily as well as ensures the repositories will be there (at least as long as you are there).

fourcolors commented 12 years ago

Ok check it https://github.com/thoughtbot/dotfiles/pull/22

mike-burns commented 12 years ago

Closing due to inactivity. We still want this. Maybe the third try is the charm.