search

thoughtbot / dotfiles

A set of vim, zsh, git, and tmux configuration files.
https://thoughtbot.com
Other
7.97k stars 1.87k forks source link

Issue with new git hooks? #327

Closed geoffharcourt closed 9 years ago

geoffharcourt commented 9 years ago

I pulled the most recent version yesterday to get the new git hooks (committed in d7f194f94ee1ab535da18e657f0c51479c0233b4), and I'm finding that brand new repositories have a weird behavior that exists until I delete the prepare-commit-msg hook from my repository's hooks directory.

When I type git commit, nothing happens. The command exits without going to vim to show a commit window, and I end up at a new shell prompt.

I'm not using any custom hooks yet, although I did experiment with them for a few minutes before I realized this problem was occurring. I deleted my hooks and the symlinks to them, and then deleted and re-downloaded a repository from Github, and have been able to reproduce the problem.

geoffharcourt commented 9 years ago

Update: If I add an echo statement to the end of prepare-commit-msg (which I assume is changing the exit status of the hook), git commit starts working again. I think this is failing if you don't have a local hook to be referenced here: https://github.com/thoughtbot/dotfiles/blob/d7f194f94ee1ab535da18e657f0c51479c0233b4/git_template/hooks/prepare-commit-msg#L4

brandoncordell commented 9 years ago

Happening for me also

croaky commented 9 years ago

Yeah, my bad guys. I think we need to return 0 in here if the .local doesn't exist.

On Dec 4, 2014, at 7:03 PM, Brandon Cordell notifications@github.com wrote:

Happening for me also

— Reply to this email directly or view it on GitHub.

brandoncordell commented 9 years ago

That fixes the issue for me

croaky commented 9 years ago

Thanks for digging into this. Closing to focus on https://github.com/thoughtbot/dotfiles/pull/328