thoughtbot / dotfiles

A set of vim, zsh, git, and tmux configuration files.
https://thoughtbot.com
Other
7.97k stars 1.87k forks source link

vim-fugitive warning when ctags found within .git directory #650

Closed andyw8 closed 4 years ago

andyw8 commented 4 years ago

There was a recent change to vim-fugitive that seems to be conflicting with how the ctags git hook works.

I'm not sure if this has always been the case, but the hook is creating a tags file within the .git directory of the repo. When vim starts, vim-fugitive emits a warning:

Fugitive .git/tags support removed in favor of `:set tags^=./.git/tags;`

(Note: For some reason, I had to first disable some custom vim config, otherwise there was a prompt, but the message wasn't visible).

The warning goes away when I add set tags^=./.git/tags to my .vimrc, but it seems Fugitive is trying to discourage this practice (there are some reasons from tpope in the PR).

eebs commented 4 years ago

I believe this was addressed in https://github.com/thoughtbot/dotfiles/pull/641. Are you up to date with master?

andyw8 commented 4 years ago

Ah, yes I was out out of date, thanks.