thoughtbot / dotfiles

A set of vim, zsh, git, and tmux configuration files.
https://thoughtbot.com
Other
7.99k stars 1.86k forks source link

Do not override :Ag command #682

Closed fievelk closed 2 years ago

fievelk commented 3 years ago

The current vimrc file is defining a custom :Ag command to use ag: https://github.com/thoughtbot/dotfiles/blob/2a59c1890f81bffc1db79cae4482ce2b706b0f79/vimrc#L97-L101

This command raises an error when I try to run it without arguments. Also, it doesn't open a new interactive window with the Ag> shell.

I believe that defining this command is not necessary nor optimal anymore. The fzf.vim plugin defines its own :Ag command. This command can't be run at the moment (because it's overridden by our vimrc).

In my opinion, the lines that define the custom :Ag command in vimrc should be removed and we should allow the :Ag command from fzf.vim to work as expected.