thoughtbot / factory_bot

A library for setting up Ruby objects as test data.
https://thoughtbot.com
MIT License
7.91k stars 2.6k forks source link

Automatically Generated: Update Dynamic Section in README #1636

Closed github-actions[bot] closed 5 months ago

github-actions[bot] commented 5 months ago

This PR was automatically generated to update the dynamic section in the README file. Whenever the README is updated, this workflow is triggered to dynamically render the snippet used in the README.

stefannibrasil commented 5 months ago

It worked 🎉

stefannibrasil commented 5 months ago

although skip ci can't be used 😭 gonna update the original repo later today.

or we can click on "Merge without waiting for requirements to be met (bypass branch protections)"?

mike-burns commented 5 months ago

What am I missing -- why isn't CI running?

stefannibrasil commented 5 months ago

CI isn't running because I added [ci-skip] in the commit message since this commit only touches documentation 🥲

One solution is to check this red checkbox:

Screenshot 2024-04-15 at 12 04 49 PM

But not sure if you'd want that. I can remove ci-skip from the workflow but I figured it makes sense to keep it to avoid running CI on README updates. Thoughts?

mike-burns commented 5 months ago

I don't understand why skip ci causes "Run standard" to need to run, and also why it isn't running.

While poking at that, I learned:

You won't be able to merge the pull request if your repository is configured to require specific checks to pass first. To allow the pull request to be merged you can push a new commit to the pull request without the skip instruction in the commit message.

https://docs.github.com/en/actions/managing-workflow-runs/skipping-workflow-runs

So maybe we just don't want skip ci.

stefannibrasil commented 5 months ago

Thank you, Mike! Removed it from the templates repo workflow. I will close this and re-open it again for the changes to be picked up 🤞