Closed composerinteralia closed 1 year ago
I looked more into the RedundantInitialize cop and it shows splat arguments as acceptable. That seems good enough here—it's not strictly the same arity, but that doesn't really matter for this null object.
RedundantInitialize
I also upgraded all the dev dependencies in https://github.com/thoughtbot/factory_bot_rails/commit/b6463a937da8e6129cbb34d7faa7f0a5b9c71b23 so we get a version of RuboCop that marks this particular cop as unsafe, and a version of standard that separates autocorrection of safe and unsafe cops. That should hopefully prevent us from incorrectly fixing unsafe cops in the future.
cc @mathieujobin
I looked more into the
RedundantInitializecop and it shows splat arguments as acceptable. That seems good enough here—it's not strictly the same arity, but that doesn't really matter for this null object.I also upgraded all the dev dependencies in https://github.com/thoughtbot/factory_bot_rails/commit/b6463a937da8e6129cbb34d7faa7f0a5b9c71b23 so we get a version of RuboCop that marks this particular cop as unsafe, and a version of standard that separates autocorrection of safe and unsafe cops. That should hopefully prevent us from incorrectly fixing unsafe cops in the future.
cc @mathieujobin