search

thoughtbot / fishery

A library for setting up JavaScript objects as test data
MIT License
877 stars 36 forks source link

Fix DeepPartial type #67 #68

Closed paulsouche closed 3 years ago

paulsouche commented 3 years ago

This PR solves issue #67

stevehanson commented 3 years ago

Thank you for this PR. This will need to also have tests demonstrating the case that this solves. Additionally, this seems to fix a somewhat particular issue. Is there a broader issue that could be addressed with a broader fix? Thanks!

paulsouche commented 3 years ago

Hello ! I added 1 commit with a test that will fail to transpile if you change the DeepPartial signature. Let me know if ok for you.

Thanks again for the great job

stevehanson commented 3 years ago

Thanks again, @paulsouche. I've opened a PR that should cover this and some other issues with DeepPartial. Take a look and let me know if it looks like it will work for you: https://github.com/thoughtbot/fishery/pull/78.

paulsouche commented 3 years ago

Hello ! Yup ! It fixes my use case. Thanks a lot ! Closing this