Completion config file error handling - Githubissues

thoughtbot / gitsh

An interactive shell for git

https://thoughtbot.com

BSD 3-Clause "New" or "Revised" License

1.96k stars 106 forks source link

Completion config file error handling #355

Closed georgebrock closed 5 years ago

georgebrock commented 5 years ago

This PR adds error reporting for problems with the tab completion. It covers several of the issues raised in #316.

Specifically:

Load the completion files on start up, so that errors happen immediately and not when the user first tries to use completion.
Output useful errors when the file fails to parse (i.e. valid tokens in an invalid order, like ??).
Output useful errors when the file contains an invalid variable (e.g. $foo)