search

thoughtbot / gitsh

An interactive shell for git
https://thoughtbot.com
BSD 3-Clause "New" or "Revised" License
1.96k stars 106 forks source link

`inputrc` test fails intermittently #360

Open georgebrock opened 5 years ago

georgebrock commented 5 years ago

e.g. https://travis-ci.org/thoughtbot/gitsh/jobs/504373680

I thought I had tracked down the cause of the problem in 08398ed39ee3bf98425ea292d8fe95e080ebe075, but it's still failing sometimes. The supposed fix did do something, because prior to that commit I could reproduce the failure locally by running RSpec with the same seed, but after that commit I can't reproduce the issue reliably.

georgebrock commented 5 years ago

Breaking up the travis.yml script into multiple lines in 92b06f143dc2668208ad7d4dd1db4b8dad628a04 seems to have helped, although I have no idea why!

georgebrock commented 5 years ago

Spoke too soon: it was just a coincidence that we had a few consecutive green runs after that change.