search

thoughtbot / griddler-cloudmailin

MIT License
2 stars 7 forks source link

Add date and BCC, and fix the "to" field #9

Closed dominicsayers closed 8 years ago

dominicsayers commented 8 years ago

Additional features:

  1. The adapter now returns the email date as a date member, derived from the email's Date header.
  2. The adapter returns any recipients who were BCCed as a bcc array.

Fixes:

  1. In version 0.0.1, the to member was incorrectly derived from the envelope's to member. In fact this never contains the data that was expected; it is a single valued field containing only the email address that received this email. Now we correctly derive the to data from the To header which includes full details of all the recipients.

Other minor changes:

  1. Added specs so this is tested to the same extent as the Sendgrid adapter.
  2. Added Rubocop and Hound configuration files so that pull requests are not spammed by Hound messages.
  3. Incremented the major version number because the behaviour of the to member has now slightly changed as described above.
dominicsayers commented 8 years ago

@scsmith Seems I can now push to this repo, thanks! I'll let you merge this one in case you want to do a quick review first.

scsmith commented 8 years ago

@dominicsayers thoughts on squash and merge? It seems like a good idea considering a pretty big history.

dominicsayers commented 8 years ago

@scsmith My bungling attempt to squash and merge seems to have added another commit instead :-(

Maybe I have to redo the PR as well?

dominicsayers commented 8 years ago

I managed to get 22 commits down to 2 and learned some things about git I hope to forget again quickly....