thoughtbot / griddler-sendgrid

SendGrid adapter for Griddler
MIT License
32 stars 35 forks source link

Add support for Sendgrid spam check #30

Closed nickrivadeneira closed 6 years ago

nickrivadeneira commented 6 years ago

Spam reports were added in thoughtbot/griddler#283. This PR:

parterburn commented 3 years ago

@nickrivadeneira I know this one is old, but really curious if you know if this PR makes this statement on the griddler-sendgrid gem no longer valid (specifically the part about Spam Check):

Make sure to uncheck the "Spam Check" and "Send Raw" checkboxes on the Parse Webhook settings page, otherwise the returned parsed email will have the body stripped out.

I have Spam Check unchecked given this pretty intense warning in the README, but curious if it's all groovy now with your changes. E.g. are there any downsides to checking that box in SendGrid these days?

nickrivadeneira commented 3 years ago

@parterburn Sorry, I barely recall writing this 😆. What I will say is that I believe I did have Spam Check enabled and it worked fine. One way to test would be to remove the spam_report hash from the normalized params and re-run the email_spec.rb test.