search

thoughtbot / griddler-sendgrid

SendGrid adapter for Griddler
MIT License
32 stars 35 forks source link

Fix attachment filename #6

Closed mzp closed 7 years ago

mzp commented 9 years ago

I try to received attachment files which have non-english file name(i.e. Japanese file name). But the file name of multipart header is not correct.

I send question to Sendgrid support team, and he answered "A file name of multipart's header is not correct. Please use attachment-info". So I add fix to use attachment-info instead of multipart header's file name.

ttsuru commented 9 years ago

+1

sdhull commented 8 years ago

:+1:

calebhearth commented 8 years ago

Can you add some failing tests here?

nickrivadeneira commented 8 years ago

Since this seems dead (almost 2 years since we've heard from OP), I opened a new PR with something similar and some tests.