search

thoughtbot / griddler

Simplify receiving email in Rails (deprecated)
http://griddler.io/
MIT License
1.38k stars 199 forks source link

Gem not updated? (or perhaps readme) #162

Closed gotjosh closed 10 years ago

gotjosh commented 10 years ago

While trying to use Griddler in conjunction with SendGrid I came across the following error:

/griddler-sendgrid-0.0.1/lib/griddler/sendgrid.rb:10:in<top (required)>': undefined method adapter_registry' for Griddler:Module (NoMethodError)

It seems that the adapter_registry method was added in introduced in v1.0.0 and the current gem version is 0.6.4 when the adapters were scoped out to a different gem.

I quickly solved it by using the master branch directly from github.

Either the Gem should be updated or the README, am I headed in the right direction?

gabebw commented 10 years ago

The current released version of Griddler (v0.6.4) actually includes Sendgrid funcitonality inside the gem.

You don't need to (and, as you point out, cannot) use griddler version 0.6.4 with the griddler-sendgrid gem. We extracted griddler-sendgrid from griddler for version 1.0.0 of Griddler, which is not yet released.

I recommend waiting for the release of version 1.0.0, then adding griddler-sendgrid to your Gemfile when you update.

gotjosh commented 10 years ago

Awesome, thanks. Shouldn't there at least be a small footnote in the documentation?

calebhearth commented 10 years ago

Yeah we haven't released 1.0.0 just yet. I'm glad you're using the master branch (at least for development/staging), as we're looking to turn 1.0.0-beta.2 into 1.0.0 in the next few days. In the mean time, you can use 1.0.0-beta.2 which has just been pushed to rubygems, or continue to use master.

As for documentation, it's a reasonable request but I think that since we're so close to releasing we'll not do that this time around.