search

thoughtbot / griddler

Simplify receiving email in Rails (deprecated)
http://griddler.io/
MIT License
1.38k stars 199 forks source link

Consider email_reply_parser for bodies #20

Closed ches closed 11 years ago

ches commented 11 years ago

https://github.com/github/email_reply_parser

It tries pretty hard to remove quoting junk from many mail clients. Plus one of the goals of the project is to crowdsource improvement efforts, so it'd be nice if thoughtbot's project could direct more eyes to it :mailbox_with_mail:

jayroh commented 11 years ago

oh nice ... didn't know that existed!

calebhearth commented 11 years ago

I'd be willing to entertain a Pull Request for this so that we can see that we get the same behavior as what we're currently doing.

I did notice that email_reply_parser works a little differently in that it is keeping all of the body 'parts' whereas we only keep what we are considering the significant portion and the raw body of the email, but that could be reconciled with some doing.

Thanks for the link, @ches. I'm going to go ahead and close this for now, but like I said we'd be glad to see a code spike in the form of a Pull Request to integrate the gem.

ches commented 11 years ago

Thanks for the consideration guys, understand your stance completely. We've basically already implemented Griddler's functionality in an app I'm working on (good thinking to plugin-ize it), so I can't say I'll immediately have time to devote to it, but I may come back around to it at some point.