search

thoughtbot / ios-on-rails

A guide to building a Rails API and iOS app
Other
76 stars 6 forks source link

Spec Discrepancy #107

Closed akwilliamson closed 9 years ago

akwilliamson commented 9 years ago

in this spec lines 23 and 33 you are expecting the id to be returned however in the iOS-On-Rails book it's written to expect the device_token to be returned as seen from the screenshot below. screen shot 2015-01-21 at 4 30 48 pm .

And the order has been switched. Just FYI in case you wanted to update the e-book. Cheers

jessieay commented 9 years ago

hey! you are right, the markdown and the book text are not exactly in the same place. This is because there were some changes on the rails side that needed to be updated on the iOS side in order for them to work together.

@dazmuda can you remind me if the ios side is looking for the even owner id when getting a nearest event? if so, we can do a new build of the book!

dazmuda commented 9 years ago

Sure thing!

On the iOS side, we're looking for the user's ID. So, we want "owner" => { "id" => farther_event.owner.id } We want the ID rather than the device token because we want users to know each other's IDs, but not their tokens.

jessieay commented 9 years ago

@dazmuda @willia15 thanks! good to know. I will put out a new build of the book soon!

akwilliamson commented 9 years ago

Great! Also, is this a good way to point out discrepancies here on GitHub? I plan on purchasing "Geocoding on Rails" next and just in case I find any more minor issues in this book or the next one I'd like to help point them out in the most convenient way (not that I'll find anything).

jessieay commented 9 years ago

Yes, GitHub issues is a great place to give feedback. We should probably mention that somewhere if we don't already...will keep this issue open as a reminder to myself to both put out a new build and add info about where to report issues etc. :rainbow:

jessieay commented 9 years ago

Hey @willia15 - I looked at the epub / mobi / pdf versions on github, and they did have the updated code (see links in README) so I figured the version you have was from gumroad. Just updated the versions on there - feel free to re-download there or just check out the versions linked to in the README, because they should be the same.

Let us know if you find any more discrepancies! Closing this issue for now

akwilliamson commented 9 years ago

@jessieay yeah I purchased and downloaded from gumroad but I'll be sure to download the other version. Thanks!