jessieay
commented
9 years ago Awesome! Looping in @dazmuda - Diana, if all of these changes look good you can just merge the branch. If some need to be reverted, you can check out to branch (I use hub for that) and revert some before merging. Let us know when you think you will be able to do this so we can set a target date for releasing book out of beta!
— Sent from Mailbox
On Sun, Jan 25, 2015 at 3:36 PM, John Meyer notifications@github.com wrote:
I have completed my edits on the iOS section of the book. Aside from a stray typo or two, nearly all of my changes were just meant to add a bit more clarity, or to improve a sentence's cadence. I do recommend that, in a couple of places where parallel chapters address alternative approaches, a line or two be inserted to explicitly acknowledge both the differences between the two approaches but also that many of the steps are identical. You can view, comment on, or merge this pull request online at: https://github.com/thoughtbot/ios-on-rails/pull/109 -- Commit Summary --
- editing
- editing
- Edited introduction
- Edited intro chapter
- Edited creating geocoded get request`
- Edited creating a get request
- Update creating_a_patch_request.md
- Edited creating a post request
- Update a_new_xcode_project.md
- Edited add and event view controller
- Edited alpha and beta
- Edited api client
- Edited api client afn
- edited app skeleton
- Edited cocoapods
- Edited displaying events
- Edited event object
- Edited finishing touches
- Edited getting an event
- Edited getting and event with AFN
- Edited introduction
- Edited making the post event request
- Edited making the post user request
- Edited map view controller
- Edited posting a user
- Edited posting a user AFN
- Edited posting an event
- Edited posting an event afn
- Edited posting with the event view controller
- Edited user object
Edited viewing with the event view controller -- File Changes -- M book/iOS/a_new_xcode_project.md (2) M book/iOS/add_an_event_view_controller.md (6) M book/iOS/alpha_and_beta.md (6) M book/iOS/api_client.md (14) M book/iOS/api_client_afn.md (2) M book/iOS/app_skeleton.md (4) M book/iOS/cocoapods.md (10) M book/iOS/displaying_events.md (6) M book/iOS/event_object.md (6) M book/iOS/finishing_touches.md (6) M book/iOS/getting_an_event.md (8) M book/iOS/getting_an_event_afn.md (4) M book/iOS/introduction.md (10) M book/iOS/making_the_post_event_request.md (6) M book/iOS/making_the_post_user_request.md (8) M book/iOS/map_view_controller.md (24) M book/iOS/posting_a_user.md (18) M book/iOS/posting_a_user_afn.md (6) M book/iOS/posting_an_event.md (6) M book/iOS/posting_an_event_afn.md (6) M book/iOS/posting_with_the_event_view_controller.md (8) M book/iOS/user_object.md (8) M book/iOS/viewing_with_the_event_view_controller.md (8) M book/introduction/introduction.md (12) M book/rails/creating_a_geocoded_get_request.md (100) M book/rails/creating_a_get_request.md (72) M book/rails/creating_a_patch_request.md (62) M book/rails/creating_a_post_request.md (114) M book/rails/introduction.md (75) -- Patch Links -- https://github.com/thoughtbot/ios-on-rails/pull/109.patch https://github.com/thoughtbot/ios-on-rails/pull/109.diff
Reply to this email directly or view it on GitHub: https://github.com/thoughtbot/ios-on-rails/pull/109
dazmuda
I have completed my edits on the iOS section of the book. Aside from a stray typo or two, nearly all of my changes were just meant to add a bit more clarity, or to improve a sentence's cadence. I do recommend that, in a couple of places where parallel chapters address alternative approaches, a line or two be inserted to explicitly acknowledge both the differences between the two approaches but also that many of the steps are identical.