thoughtbot / ios-on-rails

A guide to building a Rails API and iOS app
Other
76 stars 6 forks source link

Chapters not defined #45

Closed seanarnold closed 10 years ago

seanarnold commented 10 years ago

I'd love to fix this myself, but you seem to have removed the option as your paperback gem is now private.

Anyway, the Chapters are not defined properly. I.e in the Kindle app with the .mobi version it looks like this:

screen shot 2014-04-22 at 3 36 35 pm

Whereas in another ebook of mine it looks like this:

screen shot 2014-04-22 at 3 37 14 pm

Hope you can fix this :)

jessieay commented 10 years ago

Hi @seanarnold ! Thank you for bringing this to our attention.

I just submitted an issue on the paperback repo. I'm not too familiar with the code base, so not sure if this is a new problem or how the gem has always worked. Will get you an answer as soon as I can! :)

seanarnold commented 10 years ago

Awesome thanks @jessieay.

Any particular reason why you've keen paperback private?

jessieay commented 10 years ago

That's a good question! There are quite a few dependencies (7 homebrew packages), so I imagine that open sourcing it might cause some headache with people having trouble getting it up and running. It also uses a font that is currently for purchase only...so basically, my guess is that it was built as an internal tool and would need some spiffing up before being open sourced.

But I will get a better answer to that while I am talking to the guys who are more familiar with it. I am interested to know, too!

jessieay commented 10 years ago

Hey @seanarnold - turns out this was because we were defining chapter titles as h2 headers instead of h1. Just fixed that and pushed but am having trouble testing the mobi version. Can you help me confirm that the newest version fixed this issue? Newest build is here: https://github.com/thoughtbot/ios-on-rails/raw/master/release/ios-on-rails.mobi

seanarnold commented 10 years ago

screen shot 2014-05-03 at 12 33 13 pm

Looks good! Thanks

jessieay commented 10 years ago

awesome - thanks for the quick reply! closing this issue now. have a great weekend! :)