thoughtbot / ios-on-rails

A guide to building a Rails API and iOS app
Other
76 stars 6 forks source link

Problems with share and edit buttons #55

Closed nicolo closed 9 years ago

nicolo commented 10 years ago

I just finished this section https://github.com/thoughtbot/ios-on-rails/blob/master/book/iOS/confirmation_view_controller.md

I don't see the edit or share buttons. I'm not really sure what needs to happen for me to see them. Seems like something is missing.

Is there something I should check is in my code to get these to display?

dazmuda commented 10 years ago

Thanks for bringing this to my attention!

The missing steps are in these sentences:

Those are definitely too vague. I'm going to go back and revise those to say:

I'm also going to include this code snippet:

// HUMConfirmationViewController.m
- (void)viewDidLoad
{
    [super viewDidLoad];
    [self createShareButton];
    [self createEditButton];
}

Basically, we need to call the createShareButton and createEditButton methods that we just created for those to be created and added to the view. I'll make that more explicit, and will pull them out into their own code snippet for clarity.

Again, thanks so much for bringing this up so I can make that change!

nicolo commented 10 years ago

I looked at the app and had this in my HUMConfirmationViewController.m

I feel like I'm missing something bigger here. I've never created and event in the iPhone version of the app. I also haven't done anything to implement the "Done" button after clicking add event. What are the steps I need to take so that I can get to this view? https://github.com/thoughtbot/ios-on-rails/blob/master/book/images/ios_app_skeleton_3.png

jessieay commented 10 years ago

@dazmuda any thoughts on @nicolo's last question? (wish I could be of more help!)

dazmuda commented 9 years ago

@nicolo I actually decided to nix the confirmation view controller since it's a bit of sugar that isn't necessary for the general iOS-interacting-with-your-rails-api purpose of the book.

You feedback prompted the question "Do we need this section?" so I really appreciate it. I'm going to close this issue.

Re: your comment about making a POST to /events. I've put in a PR https://github.com/thoughtbot/ios-on-rails/pull/92 that has much better instructions for making a POST to /events with fake data and for making a POST to /events with user-inputted data. Thanks for pointing that out.