search

thoughtbot / ios-on-rails

A guide to building a Rails API and iOS app
Other
76 stars 6 forks source link

Added address validation. #72

Closed jessewaites closed 10 years ago

jessewaites commented 10 years ago

...orry if not cool or Im wrong.

jessieay commented 10 years ago

Hi Jesse - Thanks for the PR!

Validations happen at the time of creation. So if we add a validation to address, we have to do the geocoder lookup before we save an event (don't think this is currently being done, although I could be wrong).

Also, just as an FYI, it's always best to keep git commit messages under 70 characters so they can be easily read on GitHub. Further detail can be put below in bullet points if you are doing a visual commit (git commit -v).

Closing this PR, but comment or reopen if you think I've missed something.

jessewaites commented 10 years ago

Gotcha- thanks- now I know!

Wonderful book, by the way. I have an interview with an iOS shop in a few hours and I'm really glad I was able to work through the book- it will give me something to talk about and a dash of experience with building APIs. I appreciate it!

Sent from my iPhone

On May 28, 2014, at 8:57 AM, "Jessie A. Young" notifications@github.com wrote:

Hi Jesse - Thanks for the PR!

Validations happen at the time of creation. So if we add a validation to address, we have to do the geocoder lookup before we save an event (don't think this is currently being done, although I could be wrong).

Also, just as an FYI, it's always best to keep git commit messages under 70 characters so they can be easily read on GitHub. Further detail can be put below in bullet points if you are doing a visual commit (git commit -v).

Closing this PR, but comment or reopen if you think I've missed something.

— Reply to this email directly or view it on GitHub.