search

thoughtbot / ios-on-rails

A guide to building a Rails API and iOS app
Other
76 stars 6 forks source link

fix humon-database-representation image path #84

Closed hangsu closed 10 years ago

hangsu commented 10 years ago

Path was pointing to book/rails/images. Needs to be book/images

before: image

after: image

jessieay commented 10 years ago

Hi! Thank you for the pull request. I merged it in and then remembered that we'd had issues with this before. I've actually made this change once before, and then it turned out that moving the image broke it in the PDF / ebook versions. See: https://github.com/thoughtbot/ios-on-rails/commit/e050640ab57784454233f69fb549475e78524c2f#diff-d35f2a61555ee0c820469627f5cfb82d

Annoying that they are different. Will make an issue on the library we use to put together the different versions to see if we can make the path work for HTML and other versions.

Closing this PR for now. :)