search

thoughtbot / ios-on-rails

A guide to building a Rails API and iOS app
Other
76 stars 6 forks source link

Creating a GET request: Instruction on installing Jbuilder missing #96

Closed jakobzeitler closed 9 years ago

jakobzeitler commented 9 years ago

I was going through the book and while working through "Creating a GET request" I noticed that the Jbuilder gem was missing. I thought that it was part of Suspenders, which the book kind of suggested, but it was not. Maybe hard to understand for a beginner. Installed the gem and everything worked fine. Just expected there to be an instruction on installing it.

jessieay commented 9 years ago

Hi there! I believe the gem is included in the introduction. But I agree that it might be better added in the GET request section. Feel free to open a PR with the addition or I can do it when I find time! 

— Sent from Mailbox

On Mon, Dec 8, 2014 at 4:35 PM, jakobzeitler notifications@github.com wrote:

I was going through the book and while working through "Creating a GET request" I noticed that the Jbuilder gem was missing. I thought that it was part of Suspenders, which the book kind of suggested, but it was not. Maybe hard to understand for a beginner.

Reply to this email directly or view it on GitHub: https://github.com/thoughtbot/ios-on-rails/issues/96

jakobzeitler commented 9 years ago

I feel like I am missing something, but this part suggests that no gems need to be added to the Gemfile (which is the case though with Jbuilder) at any point when using Suspenders:

"While Suspenders is not required to follow along with this book, it does conveniently include all of the gems we will use to test-drive our API, including: Factory Girl, RSpec, and Shoulda Matchers. So if you choose not to use Suspenders to start your project, make sure you add those gems to your Gemfile."

"it does […] include all of the gems we will use to test-drive our API" suggests that Jbuilder is part of Suspenders.

jessieay commented 9 years ago

JBuilder is referenced in the introduction here: https://github.com/thoughtbot/ios-on-rails/blob/master/book/rails/introduction.md#generating-outgoing-json-responses

Agreed that the gem / install should be mentioned in the chapter where it is first used. Perhaps in this section: https://github.com/thoughtbot/ios-on-rails/blob/master/book/rails/creating_a_get_request.md#view

If you want to take a shot at it, I'd love to review / merge your PR! Otherwise, will need to work on getting that change incorporated a bit later.

jessieay commented 9 years ago

This appears to be resolved, so I am closing the issue. :rainbow: :rainbow: