search

thoughtbot / laptop

A shell script to set up a macOS laptop for web and mobile development.
https://thoughtbot.com
MIT License
8.5k stars 1.91k forks source link

Hub install fails if `~/.bin` does not exist #134

Closed jayroh closed 11 years ago

jayroh commented 11 years ago

Easy enough fix to mkdir if it doesn't exist. Leaving this as an issue until I (or someone) can get around to submitting a PR.

jayroh commented 11 years ago

Adding $HOME/.bin to $PATH would be a good idea too as right now hub is not found by default after a clean install

kevinSuttle commented 11 years ago

Is this something that @defunkt should look into for hub?

kevinSuttle commented 11 years ago

Also, would sourceing your .zshrc resolve this?

pbrisbin commented 11 years ago

I think this problem arises from the implicit coupling between laptop and dotfiles. I'd rather see us move away from that coupling rather than continue to support it...

What about just installing hub system wide? I believe this can be done via brew on Mac and we can just install standalone to /usr/bin/ on Linux.

kevinSuttle commented 11 years ago

Related: https://github.com/thoughtbot/laptop/issues/129

djcp commented 11 years ago

/usr/bin is supposed to be distro-managed binaries, if we wanted to do a system-wide install in linux we'd probably dump it in /usr/local/bin. Personally, I don't see why this shouldn't go into $HOME/.bin/, seems logical if we're not able to install it via a package manager.

kevinSuttle commented 11 years ago

Yeah, I agree, ~/.bin is a good place.

djcp commented 11 years ago

fixed in https://github.com/thoughtbot/laptop/commit/c56f081af0969f60a87efc2d7d04947088d72444