search

thoughtbot / laptop

A shell script to set up a macOS laptop for web and mobile development.
https://thoughtbot.com
MIT License
8.51k stars 1.91k forks source link

Update asdf plugins already installed #554

Closed sparksp closed 5 years ago

sparksp commented 5 years ago

Keep any asdf plugins installed by this script up-to-date.

This may resolve some issues when updating languages, especially nodejs where the asdf plugin maintains the signing keys required to verify the package.

I chose add_or_update_asdf_plugin rather than install_or_update_asdf_plugin to keep the line lengths shorter when being called - it also matches the asdf api.

We maintain an alias for install_asdf_plugin incase anyone's laptop.local uses it.

composerinteralia commented 5 years ago

I like this change. I have been bit by forgetting to update asdf plugins a couple times now.

I do see some people using install_asdf_plugin in the laptop.local, so we probably do want to keep that around. (I did a quick search and found https://github.com/stackng/dev-env-as-code/blob/c31e25cdca49346cd645fecfe4f4d5a5704eaff2/laptop.local and https://github.com/jedschneider/laptop-local/blob/0bca5b296b24ff732652a5df845960c7ef584524/laptop-local, for example.)

sparksp commented 5 years ago

I've added an alias for install_asdf_plugin.