search

thoughtbot / laptop

A shell script to set up a macOS laptop for web and mobile development.
https://thoughtbot.com
MIT License
8.51k stars 1.91k forks source link

Add support for macOS Ventura #621

Closed cpytel closed 1 year ago

cpytel commented 2 years ago

Closes #617

This adds support for macOS Ventura. It also introduces a build matrix on CI to run the build on moth Monterey and Ventura.

cpytel commented 2 years ago

An update on this, CI seems to be hitting this error that people are reporting with 3.1.2 on Ventura:

I have tried the suggestions in those documents, but haven't been able to get Ruby to build on the macOS ventura issue used by CI. I've installed tart and the image locally and get the same error. However, it is working locally for me in a fresh install of Ventura running in UTM. This is consistent with people's reports in the discussions, where one some machines it works fine and others, it doesn't.

It looks to me like maybe this has been identified as a bug in Ruby (https://bugs.ruby-lang.org/issues/18912) and a fix has been merged here: https://github.com/ruby/ruby/pull/6193, but that fix has not made it to a stable Ruby release yet.

So, while some people may be able to use the current version of the script successfully on Ventura, it may fail for others, so I'm hesitant to declare that it is officially supported yet.

cpytel commented 1 year ago

Agreed, I was just trying that to see if it would work, but it doesn't.

cpytel commented 1 year ago

Last week Ruby 3.1.3 was released and the notes say

This release also includes a fix for build failure with Xcode 14 and macOS 13 (Ventura). See the related ticket for more details.

I will be able to take another look at this on Friday.