Remove mimemagic as it now released under a GPL license, incompatible with Paperclip's MIT license

thoughtbot / paperclip

Easy file attachment management for ActiveRecord

https://thoughtbot.com

Other

9.01k stars 2.43k forks source link

Remove mimemagic as it now released under a GPL license, incompatible with Paperclip's MIT license #2677

Closed sd closed 3 years ago

sd commented 3 years ago

NOTE: this is still untested work in progress.

Opened this PR in case anyone wants to help me.

See https://github.com/rails/rails/issues/41750 for more info.

Issue https://github.com/thoughtbot/paperclip/issues/2678

NOTE: Since paperclip has mandatory spoof detection, you will need to have the file command installed on your server in order for file uploads to keep working.

ghiculescu commented 3 years ago

might be worth doing this on https://github.com/kreeti/kt-paperclip too

alexshenia commented 3 years ago

mimemagic returned back MIT license, I do not think that we need this changes anymore

mathieujobin commented 2 years ago

Actually, I am using this branch... I like to remove dependencies when they are not needed. Could this be flipped into an optional dependency? I don't know if there are people who prefer to use mimemagic for some reason. My vote would be to merge this

thanks