search

thoughtbot / paperclip

Easy file attachment management for ActiveRecord
https://thoughtbot.com
Other
9.01k stars 2.43k forks source link

Replace mimemagic with marcel gem #2684

Closed pjmartorell closed 3 years ago

pjmartorell commented 3 years ago

Replace mimemagic with marcel gem. Resolves https://github.com/thoughtbot/paperclip/issues/2678

pjmartorell commented 3 years ago

@mike-burns or any other maintainer, I think this issue should be addressed in order to circumvent the issue with mimemagic not being compliant with the GPL license.

mike-burns commented 3 years ago

But mimemagic is MIT licensed. Do we need to do a thing here?

pjmartorell commented 3 years ago

yes, but they circumvented the issue with GPL downloading the problematic GPL file at runtime instead of including it in the source code, which is not an option for environments were the communication with the outside world is restricted.

mike-burns commented 3 years ago

Those environments will need to install the shared-mime-info package. They already need to install other packages (ImageMagick, Ruby, etc.), so I'm not terribly concerned.

Since this isn't a license violation for Paperclip, and since Paperclip is deprecated, I'm going to close this. Thank you for bringing it up.