search

thoughtbot / parity

Shell commands for development, staging, and production parity for Heroku apps
https://thoughtbot.com
MIT License
889 stars 57 forks source link

Fix pr_app executable #163

Closed geoffharcourt closed 5 years ago

geoffharcourt commented 5 years ago

The pr_app command was broken in two ways. First, it had a mismatching argument name for the app/environment flag, resulting in an error whenever it was called. Second, it was missing the -pr- as part of the Heroku review app name, so it would never find the correct application. These changes are hard to test with an executable vs. a more OO-based piece of code, but this change was tested against a real application and worked correctly.

mjankowski commented 5 years ago

Wild stuff. Is there anything simple we could have had in place here to catch the switch/app_argument thing?