search

thoughtbot / parity

Shell commands for development, staging, and production parity for Heroku apps
https://thoughtbot.com
MIT License
889 stars 57 forks source link

Add support for 3-tier database configurations on development #182

Closed horacio closed 2 years ago

horacio commented 4 years ago

Hi! I noticed parity doesn't get along with multi-database configurations, so I was thinking it could be nice to support this. This patch shows a rough idea of the needed changes, but I wanted to make sure I'm heading in the right direction. Any comments would be greatly appreciated.

geoffharcourt commented 3 years ago

Hi @horacio I am quite sorry for missing this PR, it came up while I was very short on time. I think this looks like it's workable. If you re-open it I can approve this week.

horacio commented 3 years ago

@geoffharcourt don't worry, and thanks for re-opening it! I'd be glad to work on this again. I'll continue with the specs for this addition, if that's OK.

geoffharcourt commented 3 years ago

@horacio sounds great. Tag me when you're ready with specs and I'll review again. Thanks for your time and effort.

horacio commented 2 years ago

Hey @geoffharcourt, first of all I just wanted to apologize for taking more than a year to get to this.

I both rebased against master and added a few changes to the PR, and I was wondering about your thoughts on supporting this and what do you think would be needed to accomplish that. Thanks!

horacio commented 2 years ago

@croaky Hey there! Could you please, whenever you can, take a look at this changes? Do you think they make sense? What would be needed to move this forward? Thanks in advance.

geoffharcourt commented 2 years ago

@horacio sorry for the lack of feedback here. Can you squash your 5 commits down to 1 commit, make sure the commit message and body explain the problem and why we're making this change, and then I can merge it and cut a release this week.

Thank for your work here!

horacio commented 2 years ago

@geoffharcourt thank you for being so generous with your time on my first pull request!

I made the solicited changes. Please let me know if something needs to be changed / reworded on the commit message to make it clearer.

megatux commented 2 years ago

Is there a new version release with this change included?

geoffharcourt commented 2 years ago

@megatux v3.5.0 is released!