search

thoughtbot / parity

Shell commands for development, staging, and production parity for Heroku apps
https://thoughtbot.com
MIT License
889 stars 57 forks source link

Feature: #deploy to main or master refs #188

Closed mrjonesbot closed 3 years ago

mrjonesbot commented 3 years ago

Resolves #184

Heroku has enabled pushing to main by default in a backwards compatible manner (does not affect master branches): https://devcenter.heroku.com/changelog-items/1829

The change checks for the presence of main and the absence of master -- setting the branch ref appropriately.

Avoids manual / global git configs and doesn't break projects where master is still the default branch.

mrjonesbot commented 3 years ago

@gabebw This has been sitting for a bit, is it ready to merge?

gabebw commented 3 years ago

@mrjonesbot It looks good to me!

I don't have merge permissions on this repo, though, so it's up to someone who does to merge this.

Perhaps @geoffharcourt can merge it?

geoffharcourt commented 3 years ago

Looks great! Thank you for your contribution.