Closed geoffharcourt closed 9 years ago
@bernerdschaefer added specs to test that Parity::Environment#run
with deploy
subcommand:
@bernerdschaefer the resulting code looks better now. I'm a little worried that the intent is harder to discern from the way it's organized, but we do have specs checking that things happen in the correct order.
TL;DR: your suggestions have clearly improved this code.
Awesome. This looks great, and I'm happy to see us getting exit codes right with parity!
:+1:
v0.9.0 broke
deploy
in two ways. The first is that migrations were being checked after the deploy completed, which resulted in the check for diffs indb/migrate
always finding no differences. This change reverts to the prior pattern of caching whether migrations are pending at the start ofdeploy
before pushing to Heroku.The second is that the check for
rake
would raise an exception if a user's local bundle wasn't installed, as the shell command would return a failing status.Kernel.system
can returntrue
,false
, ornil
, butKernel.exit
can't acceptnil
as an argument.Parity::Environment#run
will now always return a boolean value so thatKernel.exit
receives an appropriate argument.Fix #61.