search

thoughtbot / pester

Automatically ask for a PR review
MIT License
148 stars 19 forks source link

LGTM Threshold #129

Open jeffutter opened 8 years ago

jeffutter commented 8 years ago

I was wondering if anyone had any thoughts on a "LGTM" threshold.

For Example: We like to have multiple devs and QA sign off on each PR.

The simplest approach would be to set a threshold (perhaps per tag or project?) so that a PR would require 3 LGTM'S before it kicks it over to being done.

A more complex solutions would be to do something like having multiple tags: #dev1 #dev2 #qa And tracking sign-off with "LGTM #qa"

If either of these solutions seem reasonable I can look into contributing a PR to add this.

drapergeek commented 8 years ago

I think a threshold for multiple sign offs is easy enough to understand could be useful in other situations. As long as it is easily configurable and can still support a single sign off, I'd happily take a PR for that :+1:

I think removing multiple tags is a bit more than something like this should be handling by default but that's my own opinion. If others feel differently I could be convinced!