Support Middleman 4 - Githubissues

reshleman commented 8 years ago

Attempting to generate a Middleman site with Proteus using Middleman 4 resulted in several errors when starting the server.

This resolves those errors by:

Using an updated syntax for registering extensions
Updating middleman-deploy to an alpha version that supports Middleman 4

An alternative to using a pre-release version of middleman-deploy would be to lock middleman in the Gemfile to ~> 3.4.1.

I don't have much experience with Middleman, and haven't had done a lot of testing of these changes beyond getting the server started with a newly-generated site, but this update seems to resolve the issues I encountered. Happy to hear feedback on these changes.

toobulkeh commented 8 years ago

:+1:

mrtnpro commented 8 years ago

+1, would love to see these merged soon

toobulkeh commented 8 years ago

This isn't the only thing needed to fix support for mm4. After spending a few hours with it there were still other problems that failed for me, so I just rolled back. I'd suggest locking to v3-stable until the MM core team figures out where they're headed with v4

joshuaogle commented 8 years ago

Yep this is a good start though. Middleman 4 made a ton of changes, so I think the best option might be to just do a fresh build and then make all of the customizations on top of that. Until then, this will help. Thanks!

thoughtbot / proteus-middleman

Support Middleman 4 #25