25 Added most of what we needed for Middleman 4, but was missing some of what we needed for the asset pipeline to work. Just to be doubly sure that all of Middleman 4 is in the right place, I started with a clean install of Middleman and brought back all of our changes piecemeal so nothing gets left out.
This PR:
Adds middleman-sprockets, which was removed from Middleman core. I'm really excited that Middleman is removing its dependencies on Rails, but since thoughtbot mostly does Rails projects, this is the most familiar solution.
Removes the LICENSE file but does link to Bourbon's license. This makes it so there's less chance people will forget to remove the file. We don't want to claim ownership for their projects.
Removes the views extension and the nav_link helper. I think I'm the only one who liked them.
Removes references to this project as "Proteus Middleman". Eventually I'd like to rename this project "middleman-starter". I originally wanted Proteus to be a family of kits, but I believe this would be more popular as thoughtbot/middleman-starter with Proteus as an easy way to grab various starter kits.
tysongach
commented
8 years ago
Fixes #28
25 Added most of what we needed for Middleman 4, but was missing some of what we needed for the asset pipeline to work. Just to be doubly sure that all of Middleman 4 is in the right place, I started with a clean install of Middleman and brought back all of our changes piecemeal so nothing gets left out.
This PR:
middleman-sprockets, which was removed from Middleman core. I'm really excited that Middleman is removing its dependencies on Rails, but since thoughtbot mostly does Rails projects, this is the most familiar solution.viewsextension and thenav_linkhelper. I think I'm the only one who liked them.thoughtbot/middleman-starterwith Proteus as an easy way to grab various starter kits.