search

thoughtbot / react-native-template

Template React Native project to be used with Cookiecutter
MIT License
61 stars 8 forks source link

Load dev tools middleware last to fix broken redux-thunk #13

Closed sharplet closed 7 years ago

sharplet commented 7 years ago

I was scratching my head as to why I couldn't get redux-thunk to work, and after inspecting one of our other apps I discovered that devTools needs to be loaded last in order not to break things. I made that change, including a comment which could be useful for documentation purposes.

sharplet commented 7 years ago

It would probably make a lot of sense to have a working redux-thunk example screen. Maybe a screen that pulls a quote from https://api.github.com/zen?

gfontenot commented 7 years ago

Oh yes this is super annoying

gfontenot commented 7 years ago

fwiw re: example - I think we should probably keep the number of examples to a minimum in the template. IMO, projects using one of these templates should be able to start with additions, as opposed to starting with deletions.

jakecraige commented 7 years ago

re: example. I my comment on another PR gets into that a bit https://github.com/thoughtbot/react-native-template/pull/9#issuecomment-279069741, but I agree it's not great to have so much implementation in here, but definitely want to provide a nice set of defaults we tend to use on every project.

I think a base level of structure and guidance for how to set things up probably makes sense, but having whole implementations like TabBars and Settings screens goes a little far. It would be neat to see if we could break out a third directory in this repo that's an example project, built off the sample one. Ideally automated but maybe it doesn't have to be at first.

sharplet commented 7 years ago

I agree with the too much implementation thing. I'm getting a little too eager seeing as this is my first time setting all this stuff up anyway! 😅