Add Circle CI config - Githubissues

thoughtbot / react-native-template

Template React Native project to be used with Cookiecutter

MIT License

61 stars 8 forks source link

Add Circle CI config #27

Closed jakecraige closed 7 years ago

jakecraige commented 7 years ago

Add configuration to run tests on Circle CI.

Update test command to run linter
Fix linting errors
Remove array bracket spacing rule since that's not the style we've used here and not one I particularly like, moreso in JSX.
Run tests in single thread on CI. See https://github.com/facebook/jest/blob/master/docs/en/Troubleshooting.md#tests-are-extremely-slow-on-docker-andor-continuous-integration-ci-server for more info.

croaky commented 7 years ago

Remove array bracket spacing rule since that's not the style we've used here and not one I particularly like, moreso in JSX.

It looks like we're using a custom style ESLint config?

Thoughts on using a community style guide that covers JSX, React, etc.? https://github.com/airbnb/javascript seems the most popular? Can be configured via https://www.npmjs.com/package/eslint-config-airbnb

jakecraige commented 7 years ago

The config we're using, except that one I just changed in this, is what's defined in our guides currently https://github.com/thoughtbot/guides/blob/master/style/javascript/.eslintrc.json, I'm not opposed to using a community guide, definitely interested in prettier as an option, but wanted to point out it's not a completely custom thing. Should we create an issue on guides?

croaky commented 7 years ago

Ah, cool.

Should we create an issue on guides?

Only if you want to! I'm generally curious to hear from the team on what they've experienced with ESLint, Prettier, Vim editor integration, and Git hooks. I've been trying to fiddle with a few things dotfiles-wise and have found it hard to get a good balance of linting based off a style guide + auto-formatting with Prettier.