search

thoughtbot / react-native-template

Template React Native project to be used with Cookiecutter
MIT License
61 stars 8 forks source link

Allowing a dash in company_name stops android build #40

Closed benfurber closed 5 years ago

benfurber commented 6 years ago

When going through the cookiecutter react-native-template setup, the second option is company_name. I put in my name with a space.

That space was changed to a dash for five locations where a package name is required, e.g.:

# /android/app/src/main/AndroidManifest.xml
...
      package="com.error-with-dash-name.appname">
...

This causes the android build to fail on :app:processDebugResources.

Removing the deadly dash enabled the build to run successfully.

sharplet commented 6 years ago

Looks like this might be the offending line: https://github.com/thoughtbot/react-native-template/blob/master/cookiecutter.json#L5

I wonder if using underscores would work?

purinkle commented 5 years ago

Allowing a dash in company_name stops android build