search

thoughtbot / react-native-template

Template React Native project to be used with Cookiecutter
MIT License
61 stars 8 forks source link

Update styles #9

Closed jakecraige closed 7 years ago

jakecraige commented 7 years ago

Rename "ralph" to "colors" This seems like what it really is and will make it less confusing to readers what it is when imported.

Add Android specific styles The tab bar on android defaults to a raw blue and looked pretty bad. This configures it for android specificly so it doesn't look so bad.

BlakeWilliams commented 7 years ago

Does this start to diverge away from a template? I think most apps will have their own opinionated way to get to a settings page and might not always follow this pattern.

jakecraige commented 7 years ago

@BlakeWilliams Yeah it does a bit. I think we'll have to figure out what the right balance of template vs. example project is as we iterate on this.

I think it's likely valuable to have the router set up this way so that the ability to present modals is ready when you need it, but we don't really need to have the button or screen for it. I think this also applies to the tab bar configuration.

At this early stage I think it's nice that someone can pull down this project and get a nice little example to modify to set up their app as well as have when developing on this, but it's also not great if the first thing I have to do when starting a project is delete a lot of code.

I wonder if there's some way we could have an example project in here, and the template project? Get the best of both worlds

jakecraige commented 7 years ago

Removed the settings screen code so we can merge this. I don't think it's too useful to have in here anymore.