thoughtbot / refills

[no longer maintained]
http://refills.bourbon.io
MIT License
1.5k stars 148 forks source link

Change $base-line-height to $base-spacing #120

Closed huwrowlands closed 10 years ago

huwrowlands commented 10 years ago

Hi,

I'm using the Pagination refill but my padding isn't functioning, looking at web dev tools the padding isn't being added because there is no 'em' unit after the numbers. See below:

padding: 0.375 0.809em;

As you can see, em is missing from the top/bottom padding. The left/right figure is called from the $gutter variable.

I am using Bourbon, Neat, Bitters and some Refills.

Thanks

kylefiedler commented 10 years ago

@huwrowlands what is the value of $base-line-height in your variables file?

huwrowlands commented 10 years ago

I believe it comes from Bourbon Bitter, _variables.css and this is the first line it appears on:

// Line height $base-line-height: 1.5;

Thanks for the reply.

kylefiedler commented 10 years ago

Change the padding on .pagination li a from padding: $base-line-height/4 $gutter/2; to padding: (($base-line-height*1em)/4) $gutter/2;

huwrowlands commented 10 years ago

That worked great. What concerns me is that I copy pasted the Pagination code from the Refills site. Would that need to be updated?

Thanks again.

kylefiedler commented 10 years ago

Yea you're right. I'm going to change the name of the issue to reflect all of Refills

huwrowlands commented 10 years ago

Thanks.

Magnus-G commented 10 years ago

This is updated now!