thoughtbot / refills

[no longer maintained]
http://refills.bourbon.io
MIT License
1.5k stars 148 forks source link

Modal close wrong alignment in example code #136

Closed etdsoft closed 9 years ago

etdsoft commented 10 years ago

I kept getting the close label left-aligned instead of the expected right-alignment.

I believe that this is caused by the following line in the sample CSS:

  .modal-close {
    @include position(absolute, ($modal-padding /2) ($modal-padding /2) 0 0);
    ///...

Which added a left: 0 declaration screwing things up. Changing it to:

    @include position(absolute, ($modal-padding /2) ($modal-padding /2) null null);

Did the trick.

Thoughts?

Magnus-G commented 10 years ago

@etdsoft yeah that's probably the right thing to do! That comes from the Bourbon/Sass heritage. I'll look into that tomorrow! Thanks

Magnus-G commented 10 years ago

@etdsoft sorry about the delay. Which version of Bourbon and bitters do you have do you know?

etdsoft commented 10 years ago

The last ones at the time of opening the ticket, I believe:

    bitters (0.10.1)
      bourbon (>= 3.2)
      sass (>= 3.2)
      thor
    bourbon (4.0.2)
      sass (~> 3.3)
      thor
    neat (1.6.0)
      bourbon (>= 3.1)
      sass (>= 3.3)
Magnus-G commented 10 years ago

@etdsoft carry on using null. We'll look into this.

Magnus-G commented 9 years ago

this should now be fixed!