search

thoughtbot / refills

[no longer maintained]
http://refills.bourbon.io
MIT License
1.5k stars 148 forks source link

_footer.scss doesn't have right markup #320

Closed tariqinaam closed 9 years ago

tariqinaam commented 9 years ago

I copied mega footer markup from refill. But it doesnt seem right. It add 80% margin-left on .footer-links class in desktop view. Not exactly sure how. desctop screenshot

vabruzzo commented 9 years ago

Did you ever figure this one out? I'm having the same issue but it wasn't 80%, its was about 35%. This pushed the columns too far to the right. I'm using lib-sass, node-neat, and bitters.

vabruzzo commented 9 years ago

This has something to do with:

.footer-links {
  @include clearfix;
  margin-bottom: $base-spacing;

  @include media($medium-screen) {
    @include shift(3);
  }
}

If I change the shift to 2.4 it looks fine. Is there some known issue with shift?

Magnus-G commented 9 years ago

@tariqinaam @vga- Hi, I have made an update to the mega footer here:

https://github.com/thoughtbot/refills/compare/mg-footer-flex?expand=1

Using flexbox instead of Neat. I think that solution is cleaner. It's still in a PR so I hope you can extract it from there and see how it works.

vabruzzo commented 9 years ago

Thanks @Magnus-G! This worked great in my case.