thoughtbot / refills

[no longer maintained]
http://refills.bourbon.io
MIT License
1.5k stars 148 forks source link

Comma missing in sliding panel scss on refills component tutorial #408

Closed trueb2 closed 7 years ago

trueb2 commented 7 years ago

When trying to use the sliding panel scss code I get the error

/path/to/sass/compiler/sass_compiler-input_base_path-0HP4aifp.tmp/app/styles/bourbon/bourbon/library/_size.scss, line 41

The Broccoli Plugin: [SassCompiler] failed with:
Error: `220px 100%` is not a valid length for the `$height` argument in the `size` mixin.

While trying to find the source of the issue, I made sure that I was using the following

The code for scss looks like

...
  $sliding-panel-color-hover: #fff;
  $sliding-panel-background-focus: lighten($sliding-panel-background, 5%);

  @include position(fixed, 0 auto 0 0);
  @include size(220px 100%);
  background: $sliding-panel-background;
  -webkit-overflow-scrolling: touch;
  overflow-y: auto;
  transform: translateX(-220px);
  transition: all 0.25s linear;
  z-index: 999999;

  ul {
    padding: 0;
    margin: 0;
  }
...

I suggest the addition of a comma, which fixed my problem

@include size(220px ,100%);
tysongach commented 7 years ago

This has been fixed.