thoughtbot / refills

[no longer maintained]
http://refills.bourbon.io
MIT License
1.5k stars 148 forks source link

Add a first pass at a modal refill #420

Closed creuter closed 7 years ago

creuter commented 7 years ago

modal

drapergeek commented 7 years ago

Code LGTM

creuter commented 7 years ago

@tysongach Yeah, I'm not sure either. Even when explicitly focusing onto the title, it's not reading it, and I'm not sure what I'm missing.

modal-title-focus

Mindpatterns follows the same pattern I did here: http://ianmcburnie.github.io/mindpatterns/disclosure/dialog/index.html

ghost commented 7 years ago

I found 1 accessibility errors:

'http://localhost:4567/ | critical | Form elements must have labels | ["#dropdown-snippets > div:nth-of-type(1) > .snippet-code.ace_editor.ace-tomorrow > .ace_text-input", "#dropdown-snippets > div:nth-of-type(2) > .snippet-code.ace_editor.ace-tomorrow > .ace_text-input", "#dropdown-snippets > div:nth-of-type(3) > .snippet-code.ace_editor.ace-tomorrow > .ace_text-input", "#modal-snippets > div:nth-of-type(1) > .snippet-code.ace_editor.ace-tomorrow > .ace_text-input", "#modal-snippets > div:nth-of-type(2) > .snippet-code.ace_editor.ace-tomorrow > .ace_text-input", "#modal-snippets > div:nth-of-type(3) > .snippet-code.ace_editor.ace-tomorrow > .ace_text-input", "#tooltipped-snippets > div:nth-of-type(1) > .snippet-code.ace_editor.ace-tomorrow > .ace_text-input", "#tooltipped-snippets > div:nth-of-type(2) > .snippet-code.ace_editor.ace-tomorrow > .ace_text-input"]'